[Lldb-commits] [PATCH] D135620: Prevent lldb-vscode tests from source lldbinit file

Mon Oct 10 16:22:21 PDT 2022

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Just add a comment as suggested and this is good to go!

================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1448-1449
+
+  auto arguments = request.getObject("arguments");
+  bool source_init_file = GetBoolean(arguments, "sourceInitFile", true);
+
----------------
Please add a comment stating this is only used for LLDB unit tests and that this isn't part of the actual packet definition for "initialize". Also state something like "When testing lldb-vscode, we never want to source the init files as these files can change the outcome of tests if the user replaces or modifies commands".

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135620/new/

https://reviews.llvm.org/D135620