[Lldb-commits] [PATCH] D134518: [lldb][COFF] Skip forwarder export symbols in symtab

[Alvin Wong via Phabricator via lldb-commits]

alvinhochun added a comment.

In D134518#3811218 <https://reviews.llvm.org/D134518#3811218>, @labath wrote:

> Ok, so is there any harm in keeping them this way?
>
> The symbols may not be very useful, but I would not say that they are useless. If, for whatever reason, the user finds himself inspecting the part of the memory covered by the forwarder string, then with this symbol, that memory would symbolicate as `forwarded_symbol+X`, which seems nice.

I guess you're right, we can keep these symbols. Though do you think it make sense to synthesize a demangled name for the symbol, let's say `ExportName (forwarded to kernel32.LoadLibrary)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134518/new/

https://reviews.llvm.org/D134518