[Lldb-commits] [PATCH] D134518: [lldb][COFF] Skip forwarder export symbols in symtab

Fri Sep 23 04:35:39 PDT 2022

labath added a comment.

In D134518#3811206 <https://reviews.llvm.org/D134518#3811206>, @alvinhochun wrote:

> In D134518#3811160 <https://reviews.llvm.org/D134518#3811160>, @labath wrote:
>
>> Where is the "dll description string" that they point to? Could they be made to point to that?
>
> The current symbol address is already pointing to it.

Ok, so is there any harm in keeping them this way?

The symbols may not be very useful, but I would not say that they are useless. If, for whatever reason, the user finds himself inspecting the part of the memory covered by the forwarder string, then with this symbol, that memory would symbolicate as `forwarded_symbol+X`, which seems nice.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134518/new/

https://reviews.llvm.org/D134518