[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

I do share the concern that Pavel has where currently RegisterInfo does not require global constructors, and it would be good to keep it this way. Right now RegisterInfo is POD which means if there is a global array of RegisterInfo structs, it gets written into a data section and there is no code that runs.

So I might recommend adding a RegisterInfo member that is a "Fields *fields" that can be easily set to NULL in POD initializers, but then stored in the dynamic register info class in its own vector and then have the RegisterInfo struct point to another POD definition of the Fields.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134041/new/

https://reviews.llvm.org/D134041