[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Looks fine to me as this is all NFC with a look toward the future. Only one questions about if we want to switch the EmulateInstruction::GetRegisterInfo to return an optional as well?



================
Comment at: lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp:785-787
 bool EmulateInstructionARM::GetRegisterInfo(lldb::RegisterKind reg_kind,
                                             uint32_t reg_num,
                                             RegisterInfo &reg_info) {
----------------
Do we want to switch this over to returning a llvm::Optional<RegisterInfo> as well in the base class?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134041/new/

https://reviews.llvm.org/D134041