[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

[Jordan Rupprecht via Phabricator via lldb-commits]

rupprecht added inline comments.


================
Comment at: lldb/test/API/lit.cfg.py:178-179
+      dotest_cmd += ['--libcxx-include-dir', config.libcxx_include_dir]
+      if is_configured('libcxx_include_target_dir'):
+        dotest_cmd += ['--libcxx-include-target-dir', config.libcxx_include_target_dir]
+      dotest_cmd += ['--libcxx-library-dir', config.libcxx_libs_dir]
----------------
JDevlieghere wrote:
> Any reason you put this before adding `config.libcxx_libs_dir` below? Same question for `lldb-dotest`. 
I did this to group together the include-related args passed to dotest.py. It shouldn't be necessary, it just helps eyeballing the args to see if dotest.py is being invoked correctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133973/new/

https://reviews.llvm.org/D133973