[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Sep 19 09:25:38 PDT 2022
JDevlieghere accepted this revision.
JDevlieghere added a comment.
LGTM
================
Comment at: lldb/test/API/lit.cfg.py:178-179
+ dotest_cmd += ['--libcxx-include-dir', config.libcxx_include_dir]
+ if is_configured('libcxx_include_target_dir'):
+ dotest_cmd += ['--libcxx-include-target-dir', config.libcxx_include_target_dir]
+ dotest_cmd += ['--libcxx-library-dir', config.libcxx_libs_dir]
----------------
Any reason you put this before adding `config.libcxx_libs_dir` below? Same question for `lldb-dotest`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133973/new/
https://reviews.llvm.org/D133973
More information about the lldb-commits
mailing list