[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

Thu Sep 15 15:24:32 PDT 2022

clayborg added a comment.

I really wish the .def files would actually generate a header file in the output directory. I am not a fan of using code navigation when saying "take me to the definition of "class Block;" and it shows:

  #define LLDB_FORWARD_CLASS(Name) class Name;
  #include "lldb-forward.def"
  #undef LLDB_FORWARD_CLASS

Also as Jim pointed out, we now will generate shared, unique, and weak pointers for everything, even if those classes  are never used that way.

I am not a fan of this. Wouldn't this also slow down compilation a bit? Each file that #include "lldb-forward.h" will not do a large amount of preprocessor stuff for each and every file that is compiled that includes this?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133906/new/

https://reviews.llvm.org/D133906