[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

[Will Hawkins via Phabricator via lldb-commits]

hawkinsw added a comment.

I hope that these comments are helpful. If they are not, please feel free to tell me to stop! I appreciated learning from reading through your discussion with @labath !



================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:265
+        :param dereference: A ValueCheck for the SBValue returned by the
+                            `Derefence` function.
         """
----------------
nit: typo `Derefence` => `Dereference`


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:19
 
-static ValueObjectSP GetCoroFramePtrFromHandle(ValueObject &valobj) {
-  ValueObjectSP valobj_sp(valobj.GetNonSyntheticValue());
+static uint64_t GetCoroFramePtrFromHandle(ValueObjectSP valobj_sp) {
   if (!valobj_sp)
----------------
Do we want to return a `lldb::addr_t`? I know that they are likely the same, but do we want it for consistency?

I see (below) several instances where we are passing around "addresses" and they are plain `uint64_t` so I am obviously being unhelpful. Sorry!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132815/new/

https://reviews.llvm.org/D132815