[Lldb-commits] [PATCH] D132577: [lldb] [Core] Pass error/status from Communication::ReadThread()

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: lldb/unittests/Core/CommunicationTest.cpp:140
+
+  // StopReadThread() can hang, so force an external timeout.
+  std::unique_lock<std::mutex> lock{finished_mutex};
----------------
labath wrote:
> I don't understand what is the purpose of this. Can you elaborate?
Arrr, I've accidentally moved this test from the MainLoop patch while rebasing. Long story short, `StopReadThread()` could hang there if we don't trigger the callbacks there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132577/new/

https://reviews.llvm.org/D132577