[Lldb-commits] [PATCH] D132577: [lldb] [Core] Pass error/status from Communication::ReadThread()

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 26 06:42:37 PDT 2022


labath added inline comments.


================
Comment at: lldb/unittests/Core/CommunicationTest.cpp:140
+
+  // StopReadThread() can hang, so force an external timeout.
+  std::unique_lock<std::mutex> lock{finished_mutex};
----------------
I don't understand what is the purpose of this. Can you elaborate?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132577/new/

https://reviews.llvm.org/D132577



More information about the lldb-commits mailing list