[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

Dave Lee via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Aug 20 11:17:29 PDT 2022


kastiglione created this revision.
kastiglione added reviewers: JDevlieghere, jingham, mib, aprantl.
Herald added a subscriber: mgorny.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Use `std::regex` as the backing implementation of `RegularExpression`.

This provides common and expected regex features, from basic features like
`\w` and `\d` character classes, to more advanced features such as lookahead.

This change used to be gated on the minimum GCC version, because some versions
of GCC had incomplete support for `std::regex`, but the GCC required by llvm
for the past couple years should be sufficient, according to docs. At this time
GCC >=7.1 is required.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132307

Files:
  lldb/include/lldb/Utility/RegularExpression.h
  lldb/source/Utility/CMakeLists.txt
  lldb/source/Utility/RegularExpression.cpp
  lldb/test/API/commands/breakpoint/set/func-regex/TestBreakpointRegexError.py
  lldb/test/API/functionalities/breakpoint/source_regexp/TestSourceRegexBreakpoints.py
  lldb/test/API/functionalities/breakpoint/source_regexp/a.c
  lldb/test/API/functionalities/breakpoint/source_regexp/main.c
  lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/multiset/TestDataFormatterGenericMultiSet.py
  lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/set/TestDataFormatterGenericSet.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132307.454239.patch
Type: text/x-patch
Size: 9624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220820/e42b8dab/attachment-0001.bin>


More information about the lldb-commits mailing list