[Lldb-commits] [lldb] d92f49f - Reland "[lldb] [test] Disable new CommunicationTests on Windows"

Michał Górny via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 19 23:33:04 PDT 2022


Author: Michał Górny
Date: 2022-08-20T08:32:55+02:00
New Revision: d92f49fc4b22a738bd39e4588543b0a23037bd69

URL: https://github.com/llvm/llvm-project/commit/d92f49fc4b22a738bd39e4588543b0a23037bd69
DIFF: https://github.com/llvm/llvm-project/commit/d92f49fc4b22a738bd39e4588543b0a23037bd69.diff

LOG: Reland "[lldb] [test] Disable new CommunicationTests on Windows"

This change was wrongly reverted and re-broke the Windows buildbot.

Sponsored by: The FreeBSD Foundation

Added: 
    

Modified: 
    lldb/unittests/Core/CommunicationTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Core/CommunicationTest.cpp b/lldb/unittests/Core/CommunicationTest.cpp
index 024684a486c2d..13ebfae772f47 100644
--- a/lldb/unittests/Core/CommunicationTest.cpp
+++ b/lldb/unittests/Core/CommunicationTest.cpp
@@ -21,6 +21,7 @@
 
 using namespace lldb_private;
 
+#ifndef _WIN32
 static void CommunicationReadTest(bool use_read_thread) {
   Pipe pipe;
   ASSERT_THAT_ERROR(pipe.CreateNew(/*child_process_inherit=*/false).ToError(),
@@ -87,7 +88,6 @@ TEST(CommunicationTest, ReadThread) {
   CommunicationReadTest(/*use_thread=*/true);
 }
 
-#ifndef _WIN32
 TEST(CommunicationTest, SynchronizeWhileClosing) {
   // Set up a communication object reading from a pipe.
   Pipe pipe;


        


More information about the lldb-commits mailing list