[Lldb-commits] [PATCH] D132263: [lldb] Support specifying a custom libcxx for the API tests

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: fdeazeve, aprantl, labath.
Herald added a project: All.
JDevlieghere requested review of this revision.

D129166 <https://reviews.llvm.org/D129166> was an attempt to ensure that by default we use the libc++ from the build dir instead of potentially picking up the system libc++. While I was reviewing D132257 <https://reviews.llvm.org/D132257>, I realized that part of the patch (i.e. the change to `Makefile.rules`) got lost. As I was reviving the code, I realized that it would be relatively straightforward to merge my change with what Felipe was trying to achieve. Instead of telling dotest to use the libc++ form the build dir and computing the path to the current build's libc++  (as was the case in D129166 <https://reviews.llvm.org/D129166>), we can specify the libc++ include and library dir to dotest (as was the case in D132257 <https://reviews.llvm.org/D132257>) and have lit compute the path to the libc++ in the build dir, achieving both objectives.


https://reviews.llvm.org/D132263

Files:
  lldb/packages/Python/lldbsuite/test/builders/builder.py
  lldb/packages/Python/lldbsuite/test/configuration.py
  lldb/packages/Python/lldbsuite/test/dotest.py
  lldb/packages/Python/lldbsuite/test/dotest_args.py
  lldb/packages/Python/lldbsuite/test/make/Makefile.rules
  lldb/test/API/lit.cfg.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132263.454110.patch
Type: text/x-patch
Size: 5810 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220819/d68a0ffa/attachment.bin>