[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

Fri Aug 19 13:28:31 PDT 2022

JDevlieghere added inline comments.

================
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:338-339

+    if args.custom_libcpp:
+        os.environ['CUSTOM_LIBCPP'] = args.custom_libcpp
+
----------------
aprantl wrote:
> JDevlieghere wrote:
> > Please don't rely on environment variables to pass arguments to the Make invocation. This makes it really tedious to debug make invocations. Instead, pass these explicitly as part of the make invocation from the builders (`packages/Python/lldbsuite/test/builders/`). 
> That is a very good point. Maybe we should just fix the -E option, which doesn't work anyway due to Makefiles setting CFLAGS_EXTRAS and use that.
I think a specific flag is fine, we already have something similar for using the "hermetic" libc++ (I left a comment below about that). We should see if we can unify this.

================
Comment at: lldb/packages/Python/lldbsuite/test/dotest_args.py:175
         help='A plugin whose tests will be enabled. The only currently supported plugin is intel-pt.')
+    group.add_argument(
+        '--custom-libcpp',
----------------
We should also think about how this interacts with `--hermetic-libcxx` (and make the name of the options consistent). 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132257/new/

https://reviews.llvm.org/D132257