[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

[Michael Buch via Phabricator via lldb-commits]

Michael137 added a comment.

In D131758#3735670 <https://reviews.llvm.org/D131758#3735670>, @mgorny wrote:

> In D131758#3735628 <https://reviews.llvm.org/D131758#3735628>, @aprantl wrote:
>
>> In D131758#3735621 <https://reviews.llvm.org/D131758#3735621>, @Michael137 wrote:
>>
>>> This seems to cause all API tests to time out.
>>>
>>> See LLDB Incremental buildbot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46215/execution/node/70/log/
>>>
>>> Can we revert this until we know what the root cause is?
>>
>> I reverted this and the follow-up commit that disables a test on Windows for now. Please let us know if you need any help in diagnosing the problem!
>
> Help would be most welcome. Unless my grep skills are failing me, the log doesn't contain anything but timeouts. I'd use at least some gdb-remote log. My only guess right now would be that debugserver doesn't support `vCont;c:-1`.
>
> Alternatively, could you try reapplying the original commit but changing:
>
>   continue_packet.Format("vCont;c:{0}-1", pid_prefix);
>
> back to:
>
>   continue_packet.PutCString("c");

@mgorny

Snippet of test log with timeout:

  ********************
  UNSUPPORTED: lldb-api :: commands/expression/call-restarts/TestCallThatRestarts.py (64 of 1755)
  TIMEOUT: lldb-api :: sample_test/TestSampleInlineTest.py (65 of 1755)
  ******************** TEST 'lldb-api :: sample_test/TestSampleInlineTest.py' FAILED ********************
  Script:
  --
  /Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/bin/python3.8 /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --codesign-identity lldb_codesign --arch x86_64 --build-dir /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex -t --env TERM=vt100 --env LLVM_LIBS_DIR=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/./lib --env LLVM_INCLUDE_DIR=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/include --env LLVM_TOOLS_DIR=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/./bin --hermetic-libcxx --arch x86_64 --build-dir /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex --lldb-module-cache-dir /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/./bin/lldb --compiler /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/./bin/clang --dsymutil /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/./bin/dsymutil --llvm-tools-dir /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/./bin --lldb-libs-dir /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/./lib /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/sample_test -p TestSampleInlineTest.py
  --
  Exit Code: -9
  Timeout: Reached timeout of 600 seconds


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131758/new/

https://reviews.llvm.org/D131758