[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

[Michał Górny via Phabricator via lldb-commits]

mgorny added a comment.

In D131758#3735628 <https://reviews.llvm.org/D131758#3735628>, @aprantl wrote:

> In D131758#3735621 <https://reviews.llvm.org/D131758#3735621>, @Michael137 wrote:
>
>> This seems to cause all API tests to time out.
>>
>> See LLDB Incremental buildbot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46215/execution/node/70/log/
>>
>> Can we revert this until we know what the root cause is?
>
> I reverted this and the follow-up commit that disables a test on Windows for now. Please let us know if you need any help in diagnosing the problem!

Help would be most welcome. Unless my grep skills are failing me, the log doesn't contain anything but timeouts. I'd use at least some gdb-remote log. My only guess right now would be that debugserver doesn't support `vCont;c:-1`.

Alternatively, could you try reapplying the original commit but changing:

  continue_packet.Format("vCont;c:{0}-1", pid_prefix);

back to:

  continue_packet.PutCString("c");


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131758/new/

https://reviews.llvm.org/D131758