[Lldb-commits] [lldb] 00c4852 - Revert "[lldb] [test] Disable new CommunicationTests on Windows"

Adrian Prantl via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 19 09:23:27 PDT 2022


Author: Adrian Prantl
Date: 2022-08-19T09:23:17-07:00
New Revision: 00c4852561a7ea51e0514759efd745ff01137b4c

URL: https://github.com/llvm/llvm-project/commit/00c4852561a7ea51e0514759efd745ff01137b4c
DIFF: https://github.com/llvm/llvm-project/commit/00c4852561a7ea51e0514759efd745ff01137b4c.diff

LOG: Revert "[lldb] [test] Disable new CommunicationTests on Windows"

This reverts commit d38985a36be8b0165787f8893b3d2b0f831d1e83.
because I'm also reverting D131758.

Added: 
    

Modified: 
    lldb/unittests/Core/CommunicationTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Core/CommunicationTest.cpp b/lldb/unittests/Core/CommunicationTest.cpp
index 13ebfae772f47..024684a486c2d 100644
--- a/lldb/unittests/Core/CommunicationTest.cpp
+++ b/lldb/unittests/Core/CommunicationTest.cpp
@@ -21,7 +21,6 @@
 
 using namespace lldb_private;
 
-#ifndef _WIN32
 static void CommunicationReadTest(bool use_read_thread) {
   Pipe pipe;
   ASSERT_THAT_ERROR(pipe.CreateNew(/*child_process_inherit=*/false).ToError(),
@@ -88,6 +87,7 @@ TEST(CommunicationTest, ReadThread) {
   CommunicationReadTest(/*use_thread=*/true);
 }
 
+#ifndef _WIN32
 TEST(CommunicationTest, SynchronizeWhileClosing) {
   // Set up a communication object reading from a pipe.
   Pipe pipe;


        


More information about the lldb-commits mailing list