[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 19 06:24:20 PDT 2022


mgorny marked an inline comment as done.
mgorny added a comment.

Ok, so I'm going to give it a shot today. Could you clarify one thing though?

> All it would take is to add some locking around the PendingCallback manipulations

Are you thinking of locking directly in `MainLoop` classes, or in the caller? It'd feel a bit inconsistent if `MainLoop`s provided locking around pending callback manipulations and not other methods. However, I suppose making everything thread-safe wouldn't hurt either.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131160/new/

https://reviews.llvm.org/D131160



More information about the lldb-commits mailing list