[Lldb-commits] [PATCH] D132217: [lldb] [Core] Harmonize Communication::Read() returns w/ thread

[Michał Górny via Phabricator via lldb-commits]

mgorny added a comment.

In D132217#3734749 <https://reviews.llvm.org/D132217#3734749>, @labath wrote:

> Cool stuff. Would it be possible to test for the two paths into a single function (with some `if`s, if necessary)? That would make it clearer what (if any) are the differences between the two modes of operation.

I suppose this makes sense (why didn't I think of it?!). I was thinking of using parametrized tests but they seemed a bit too complex for two cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132217/new/

https://reviews.llvm.org/D132217