[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

[Greg Clayton via Phabricator via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Minidump files have UUID values that are zeroed out. We will need to do something for these that can sense all zeroes and return a default constructed one.



================
Comment at: lldb/source/Plugins/Process/minidump/MinidumpParser.cpp:72
+        return UUID::fromData(pdb70_uuid, sizeof(*pdb70_uuid));
+      return UUID::fromData(&pdb70_uuid->Uuid,
                                     sizeof(pdb70_uuid->Uuid));
----------------
Minidump files created by Google's Breakpad generates UUIDs with zeros:

```
Modules[2].CvRecord.location.DataSize = 0x00000032 (50)
Modules[2].CvRecord.location.Rva = 0x000698e0
Modules[2].CvRecord.signature    = 0x53445352 (Pdb70)
Modules[2].CvRecord.uuid         = 00000000-0000-0000-0000-000000000000
Modules[2].CvRecord.age          = 0x00000000
Modules[2].CvRecord.pdb_name     = system at framework@boot.art
```
It would be fine to just check for the "pdb70_uuid->Uuid" being all zeroes here and return a default constructed UUID object


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132191/new/

https://reviews.llvm.org/D132191