[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

Left few comments :)



================
Comment at: lldb/docs/resources/fuzzing.rst:12
+
+Building the LLDB fuzzers requires a build configuration that has the address sanitizer and sanitizer coverage. This CMake invocation will configure a build directory that can be used to build the LLDB fuzzers:
+
----------------
missing word ?


================
Comment at: lldb/docs/resources/fuzzing.rst:28-33
+To build a fuzzer, run the desired ninja command for the fuzzer(s) you want to build:
+
+::
+   $ ninja lldb-target-fuzzer
+   $ ninja lldb-commandinterpreter-fuzzer
+   $ ninja lldb-expression-fuzzer
----------------
Don't we have a top-level `ninja lldb-fuzzer` command that runs all the fuzzer ? If not, what about adding that ?


================
Comment at: lldb/docs/resources/fuzzing.rst:37
+
+Note that building the LLDB expression evaluator fuzzer will require the CMake option ``-DCLANG_ENABLE_PROTO_FUZZER=ON``.
+
----------------
Is it an issue to have this enabled for the other fuzzers ? If not, may be you should just add it to the general cmake invocation 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132148/new/

https://reviews.llvm.org/D132148