[Lldb-commits] [PATCH] D132062: [lldb] [gdb-remote] Clean up the API of GDBRemoteCommunication

[Michał Górny via Phabricator via lldb-commits]

mgorny created this revision.
mgorny added reviewers: labath, emaste, krytarowski, jingham.
Herald added a subscriber: arichardson.
Herald added a project: All.
mgorny requested review of this revision.

Make the public & protected fields and methods of GDBRemoteCommunication
private if they are not used elsewhere.  This also includes the GetAck()
method that was used in unittests but did not seem essential to the test
at hand.

Remove the unused m_is_platform field.

Make ExpandRLE() a static function rather than static class method.

This is a first step towards separating the low-level packet operations
from high-level public API that is intended to be used by
ProcessGDBRemote.

Sponsored by: The FreeBSD Foundation


https://reviews.llvm.org/D132062

Files:
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
  lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132062.453396.patch
Type: text/x-patch
Size: 8114 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220817/552b6f9f/attachment-0001.bin>