[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/test/API/macosx/queues/TestQueues.py:131
 
+    def check_queue_breakpoints(self, queue1, queue2, queue_breakpoint):
+        queue1_thread = queue1.GetThreadAtIndex(0)
----------------
cassanova wrote:
> JDevlieghere wrote:
> > Any reason this should be a separate function? Can this be inlined in `queue_specific_breakpoints`?
> It can be inlined, the reason I had it in a separate function is that it matched the rest of the test in having the assertions be in their own functions.
Fair enough, this test has a different structure than most. Let's keep it this way then for consistency. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131605/new/

https://reviews.llvm.org/D131605