[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

Tue Aug 16 09:20:31 PDT 2022

Michael137 added a comment.

In D131974#3726451 <https://reviews.llvm.org/D131974#3726451>, @labath wrote:

> In D131974#3726438 <https://reviews.llvm.org/D131974#3726438>, @Michael137 wrote:
>
>>   lang/cpp/extern_c/TestExternCSymbols.py
>
> I think that's because `extern "C"` symbols don't have a DW_AT_linkage_name attribute. Generally speaking, I don't think we can assume all debug info entries will have one (e.g. `-gsce` makes clang omit those), and should add them only if available.

Yup makes sense. Checking the others. Wonder if it needs a check for `attrs.storage == SC_Extern`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131974/new/

https://reviews.llvm.org/D131974