[Lldb-commits] [PATCH] D131667: [LLDB][RISCV] Fix risc-v target build

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 16 08:37:23 PDT 2022


labath added inline comments.


================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_riscv64.cpp:54
+NativeRegisterContextLinux::DetermineArchitecture(lldb::tid_t tid) {
+  return HostInfo::GetArchitecture();
+}
----------------
DavidSpickett wrote:
> On the assumption that riscv6 linux doesn't have a 32 bit compatibility mode, this is fine.
> 
> (that's what this is trying to detect, for example running arm32 on arm64).
(even if it does, I don't think we have to support that mode right away)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131667/new/

https://reviews.llvm.org/D131667



More information about the lldb-commits mailing list