[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

[Chelsea Cassanova via Phabricator via lldb-commits]

cassanova added inline comments.


================
Comment at: lldb/test/API/macosx/queues/TestQueues.py:201-206
+        # Run the executable until the stopper function and get the breakpoint
+        # that's created from that. Then set the queue name of the breakpoint
+        # to be the name of the main thread
+        target, process, main_thread, queue_breakpoint = lldbutil.run_to_name_breakpoint(self, "stopper", only_one_thread=False)
+        queue_breakpoint.SetQueueName(main_thread.GetQueue().GetName())
+        self.check_queue_breakpoints(main_thread.GetQueue(), queue_submittor_1, queue_breakpoint)
----------------
JDevlieghere wrote:
> This seems like it should be its own test. Right now this is reassigning the target and process, which seems suspicious, and also changes the meaning of everything that comes after it. 
Good point, I'm placing the queue specific tests into their own test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131605/new/

https://reviews.llvm.org/D131605