[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

[Stella Laurenzo via Phabricator via lldb-commits]

stellaraccident added inline comments.


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:1257
+
+set(LLVM_THIRD_PARTY_DIR  ${CMAKE_CURRENT_SOURCE_DIR}/../third-party CACHE STRING
+    "Directory containing third party software used by LLVM (e.g. googletest)")
----------------
Is the implication that this file should only ever be included by top-level sub-projects (i.e. clang, mlir, llvm, etc)? If included from elsewhere, it seems like it won't do the right thing.

Also, having this as a cache entry is going to make it harder for out of tree projects to define it reliably (requiring various FORCE heroics) -- but I know why you are doing it if trying to define it here.

As is, this file is included from most of the top-levels and making it a cache variable will have them racing to set it. Why not make it a regular variable? And why not derive it from LLVM_MAIN_SRC_DIR?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131919/new/

https://reviews.llvm.org/D131919