[Lldb-commits] [lldb] 570e10c - [lldb] Fix warning: comparison of integers of different signs

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 15 11:25:51 PDT 2022


Author: Jonas Devlieghere
Date: 2022-08-15T11:25:46-07:00
New Revision: 570e10cb9def153812f13ef1945f9ef388ab3e3e

URL: https://github.com/llvm/llvm-project/commit/570e10cb9def153812f13ef1945f9ef388ab3e3e
DIFF: https://github.com/llvm/llvm-project/commit/570e10cb9def153812f13ef1945f9ef388ab3e3e.diff

LOG: [lldb] Fix warning: comparison of integers of different signs

Fixes a warning about comparison of integers of different signs
'wchar_t' and 'int' in Editline.cpp:

      return out != (int)WEOF;
             ~~~ ^  ~~~~~~~~~

Added: 
    

Modified: 
    lldb/source/Host/common/Editline.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Host/common/Editline.cpp b/lldb/source/Host/common/Editline.cpp
index ea0f06f637071..cee7a3655046a 100644
--- a/lldb/source/Host/common/Editline.cpp
+++ b/lldb/source/Host/common/Editline.cpp
@@ -1609,7 +1609,7 @@ bool Editline::CompleteCharacter(char ch, EditLineGetCharType &out) {
     switch (cvt.in(state, input.begin(), input.end(), from_next, &out, &out + 1,
                    to_next)) {
     case std::codecvt_base::ok:
-      return out != (int)WEOF;
+      return out != (EditLineGetCharType)WEOF;
 
     case std::codecvt_base::error:
     case std::codecvt_base::noconv:


        


More information about the lldb-commits mailing list