[Lldb-commits] [lldb] 4025a8a - [NFC][trace][intel pt] add simple documentation line

Walter Erquinigo via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 15 00:56:23 PDT 2022


Author: Walter Erquinigo
Date: 2022-08-15T00:56:12-07:00
New Revision: 4025a8ae934f77ec21558c40aa82937bfe74a7c3

URL: https://github.com/llvm/llvm-project/commit/4025a8ae934f77ec21558c40aa82937bfe74a7c3
DIFF: https://github.com/llvm/llvm-project/commit/4025a8ae934f77ec21558c40aa82937bfe74a7c3.diff

LOG: [NFC][trace][intel pt] add simple documentation line

Added: 
    

Modified: 
    lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp b/lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp
index 8d621c1438307..9526ad84ab328 100644
--- a/lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp
+++ b/lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp
@@ -295,7 +295,9 @@ class PSBBlockDecoder {
         break;
       case ptev_overflow:
         // The CPU internal buffer had an overflow error and some instructions
-        // were lost.
+        // were lost. A OVF packet comes with an FUP packet (harcoded address)
+        // according to the documentation, so we'll continue seeing instructions
+        // after this event.
         m_decoded_thread.AppendError(IntelPTError(-pte_overflow));
         break;
       default:


        


More information about the lldb-commits mailing list