[Lldb-commits] [PATCH] D131333: [lldb] abi_tag support 2/3 - Make FindBestAlternateFunctionMangledName local to the C++ language plugin

[Michael Buch via Phabricator via lldb-commits]

Michael137 added inline comments.
Herald added a subscriber: JDevlieghere.


================
Comment at: lldb/include/lldb/Target/Language.h:315
+  ///
+  /// \param[out] results Will contain alternative mangled
+  ///                     function names.
----------------
aprantl wrote:
> Why not return results? Are we expecting to add more results to an existing vector regularly?
No reason in particular. Just tried to keep it consistent with the other related APIs. Mainly to cause less confusion for reviewers. If we wanted to return the vector we'd have to at least change `IRExecutionUnit::CollectCandidateCPlusPlusNames` also.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131333/new/

https://reviews.llvm.org/D131333