[Lldb-commits] [PATCH] D131333: [lldb] abi_tag support 2/3 - Make FindBestAlternateFunctionMangledName local to the C++ language plugin

[Michael Buch via Phabricator via lldb-commits]

Michael137 created this revision.
Michael137 added a reviewer: aprantl.
Herald added a project: All.
Michael137 updated this revision to Diff 450757.
Michael137 added a comment.
Michael137 updated this revision to Diff 450991.
Michael137 retitled this revision from "[lldb] abi_tag support 2/4 - Make FindBestAlternateFunctionMangledName local to the C++ language plugin" to "[lldb] abi_tag support 2/3 - Make FindBestAlternateFunctionMangledName local to the C++ language plugin".
Michael137 added reviewers: labath, jingham.
Michael137 published this revision for review.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

- Rebase


Michael137 added a comment.

- Reword commit message



================
Comment at: lldb/include/lldb/Target/Language.h:315
+  ///
+  /// \param[out] results Will contain alternative mangled
+  ///                     function names.
----------------
Why not return results? Are we expecting to add more results to an existing vector regularly?


This patch makes `CPlusPlusLanguage::FindBestAlternateFunctionMangledName` local
to `CPlusPlusLanguage`. We do so by creating a new API `CollectAlternateFunctionNames`.
Both APIs are called only by `IRExecutionUnit`. However, by having
`FindBestAlternateFunctionMangledName` local to the C++ plugin we can
change its implementation in C++-specific ways, which we plan to do
in follow-up commits that add Itanium mangle tree API support to
`FindBestAlternateFunctionMangledName`.

**Testing**

- API tests still pass


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131333

Files:
  lldb/include/lldb/Target/Language.h
  lldb/source/Expression/IRExecutionUnit.cpp
  lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
  lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131333.450991.patch
Type: text/x-patch
Size: 5250 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220808/5f7f4243/attachment.bin>