[Lldb-commits] [PATCH] D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM module the inline comment.



================
Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:27-29
                     if image not in self.loaded_images:
+                        if image.uuid == uuid.UUID(int=0):
+                            print(f"Note: Skipping null image")
----------------
Sounds good. I would remove the print and just ignore the null images. There's nothing actionable there for the user.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131038/new/

https://reviews.llvm.org/D131038