[Lldb-commits] [PATCH] D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode

[Med Ismail Bennani via Phabricator via lldb-commits]

mib marked 2 inline comments as done.
mib added inline comments.


================
Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:28
                     if image not in self.loaded_images:
+                        if image.uuid == uuid.UUID(int=0):
+                            print(f"Note: Skipping null image")
----------------
JDevlieghere wrote:
> jasonmolenda wrote:
> > One of the things I noticed working on https://reviews.llvm.org/D130813 was that our UUID class's IsValid() method detects if the object has any bytes or not, and I wonder if it should check for a null uuid value (all zeroes) and return IsValid()==false in that case. In my patch, I was reading a UUID out of a corefile and I needed to check if it was a null uuid before I copied the bytes into a UUID object to work around it.
> According to the spec [1], the all-zero UUID is indeed a special case called the "Nil UUID". I think it makes sense to have IsValid return false for that. 
> 
> [1] https://datatracker.ietf.org/doc/html/rfc4122#section-4.1.7
Sounds good to me but I think that change is unrelated to this patch: The problem here that we call `dsymForUUID` from `crashlog.py -> DarwinImage:locate_module_and_debug_symbols` with a nil UUID, so the issue is external to lldb. I'll make the UUID::IsValid change on a follow-up patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131038/new/

https://reviews.llvm.org/D131038