[Lldb-commits] [PATCH] D128989: [lldb] [llgs] Support resuming multiple processes via vCont w/ nonstop

[Michał Górny via Phabricator via lldb-commits]

mgorny marked 2 inline comments as done.
mgorny added a comment.

Thanks!



================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1786
+    if (pid == StringExtractorGDBRemote::AllProcesses) {
+      for (auto &process_it : m_debugged_processes)
+        thread_actions[process_it.first].Append(thread_action);
----------------
labath wrote:
> https://sourceware.org/gdb/onlinedocs/gdb/Packets.html#Packets says "It is an error to specify all processes but a specific thread, such as ‘p-1.tid’", so I guess this should error out if `tid != AllThreads`.
Makes sense. For some reason, I thought we've covered it somewhere but maybe it got lost in refactoring.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128989/new/

https://reviews.llvm.org/D128989