[Lldb-commits] [PATCH] D128989: [lldb] [llgs] Support resuming multiple processes via vCont w/ nonstop

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good modulo the comments.



================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1786
+    if (pid == StringExtractorGDBRemote::AllProcesses) {
+      for (auto &process_it : m_debugged_processes)
+        thread_actions[process_it.first].Append(thread_action);
----------------
https://sourceware.org/gdb/onlinedocs/gdb/Packets.html#Packets says "It is an error to specify all processes but a specific thread, such as ‘p-1.tid’", so I guess this should error out if `tid != AllThreads`.


================
Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteForkNonStop.py:153
+            {"direction": "send", "regex": "%Stop:T.*"},
+            # see the comment in TestNonStop.py, test_stdio
+            "read packet: $vStdio#00",
----------------
See cd18e2ea3f4e87f8804a7d6661d5596ef1f07b81 for why that does not work.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128989/new/

https://reviews.llvm.org/D128989