[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Looks good. I would just inline the contents of shadowed_bkpt_locations_setters_getters_test into test_shadowed_location_getters_setters since it isn't use anywhere else.



================
Comment at: lldb/test/API/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py:29
+        self.build()
+        self.shadowed_bkpt_locations_setters_getters_test()
+
----------------
unless you plan on re-using shadowed_bkpt_locations_setters_getters_test() I would just inline the function's contents here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130660/new/

https://reviews.llvm.org/D130660