[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Sorry for dropping off.

Using the mangled name helped, but I am still moderately worried about that the name that's going to be matched here is different from the "real" name that gets computed later <https://github.com/llvm/llvm-project/blob/main/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp#L2305>. I think it's important to avoid subtle variations in the names computed in two places, and that's only possible with a single copy of the code (*that* was my biggest issue with the `GetQualifiedNameWithParams` function). Functions without a mangled name are relatively common (all `extern "C"` functions, and *all* functions if compiled with `-gsce`) and I think it'd be confusing if we used one name for matching, and then displayed another one.

The exact string is probably not as important as consistency so I think we could replace the code I linked to with whatever can be produced with the information you have available here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129682/new/

https://reviews.llvm.org/D129682