[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:37
+    Mangled mangled_name(die.GetMangledName());
+    if (!lookup_info.NameMatchesLookupInfo(mangled_name.GetDemangledName(),
+                                           lookup_info.GetLanguageType()))
----------------
bulbazord wrote:
> clayborg wrote:
> > So this looks like this can be called with an empty named since not all DIEs have mangled names. Do we not want to try and calculate the demangled name here if the mangled name is empty?
> Yes, we probably do want to calculate the demangled name here. The previous version of this patch had a function `GetQualifiedNameWithParams` that tried to calculate the fully qualified demangled name but I think it probably needed a little more work. I can bring that back unless you can think of a different way to do it.
You can avoid doing this demangling or calculating the demangled name if the name in the lookup_info is already mangled? Like if the name lookup is "_Z3foo", there is no need to demangle and see if that matches, so there could be some good efficiency gains by trying not to always demangle (expensive) or calculate the demangled named (even more expensive) if we are looking for a mangled name in lookup_info


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129682/new/

https://reviews.llvm.org/D129682