[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

Fri Jul 22 13:55:40 PDT 2022

mstorsjo added a comment.

In D130309#3672934 <https://reviews.llvm.org/D130309#3672934>, @clayborg wrote:

> Submitted a fix for the buildbots:
>
> commit f959d815f4637890ebbacca379f1c38ab47e4e14 <https://reviews.llvm.org/rGf959d815f4637890ebbacca379f1c38ab47e4e14> (HEAD -> main)
> Author: Greg Clayton <gclayton at fb.com>
> Date:   Fri Jul 22 13:24:04 2022 -0700
>
>   Fix buildbot breakage after https://reviews.llvm.org/D130309.

Still broken for me:

  ../tools/lldb/source/Host/linux/HostInfoLinux.cpp: In static member function ‘static bool lldb_private::HostInfoLinux::ComputeSupportExeDirectory(lldb_private::FileSpec&)’:
  ../tools/lldb/source/Host/linux/HostInfoLinux.cpp:174:64: error: passing ‘const lldb_private::ConstString’ as ‘this’ argument discards qualifiers [-fpermissive]
    174 |   file_spec.GetDirectory() = GetProgramFileSpec().GetDirectory();
        |                                                                ^
  In file included from ../tools/lldb/include/lldb/Utility/ArchSpec.h:13,
                   from ../tools/lldb/include/lldb/Host/HostInfoBase.h:12,
                   from ../tools/lldb/include/lldb/Host/posix/HostInfoPosix.h:12,
                   from ../tools/lldb/include/lldb/Host/linux/HostInfoLinux.h:12,
                   from ../tools/lldb/source/Host/linux/HostInfoLinux.cpp:9:
  ../tools/lldb/include/lldb/Utility/ConstString.h:40:7: note:   in call to ‘constexpr lldb_private::ConstString& lldb_private::ConstString::operator=(const lldb_private::ConstString&)’
     40 | class ConstString {
        |       ^~~~~~~~~~~

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130309/new/

https://reviews.llvm.org/D130309