[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 22 13:44:36 PDT 2022


JDevlieghere added inline comments.


================
Comment at: lldb/source/Utility/ArchSpec.cpp:1390-1395
+  case ArchSpec::eCore_riscv64:
+    if (!enforce_exact_match) {
+      if (core2 == ArchSpec::eCore_riscv64)
+        return true;
+    }
+    break;
----------------
I don't think this is needed. The case where the two cores are identical is already covered by line 1084. This would be for something like `eCore_riscv32` if that were a thing. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130342/new/

https://reviews.llvm.org/D130342



More information about the lldb-commits mailing list