[Lldb-commits] [PATCH] D130340: [lldb] [gdb-remote] Refactor killing process and move it to client

[Michał Górny via Phabricator via lldb-commits]

mgorny created this revision.
mgorny added reviewers: labath, krytarowski, emaste, jingham.
Herald added a subscriber: arichardson.
Herald added a project: All.
mgorny requested review of this revision.

Refactor the code responsible for sending the "k" packet and move it
into GDBRemoteCommunicationClient::KillProcess() method.  This is part
of refactoring to enable multiprocess support in the client,
and to support using the vKill packet instead.

As part of the refactoring, the following functional changes apply:

- Some redundant logging has been removed, as any failures are returned via exit_string anyway.

- SetLastStopPacket() is no longer called.  It is used only to populate the thread list, and since the process has just exited and we're terminating the process instance, there's really no reason to set it.

- On successful kill, exit_string is set to "killed", to clearly indicate that the process has terminated on our request rather than on its own.

Sponsored by: The FreeBSD Foundation


https://reviews.llvm.org/D130340

Files:
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130340.446760.patch
Type: text/x-patch
Size: 6260 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220722/6454e416/attachment.bin>