[Lldb-commits] [PATCH] D130320: Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp

[Sujin Park via Phabricator via lldb-commits]

persona0220 created this revision.
persona0220 added reviewers: wallace, jj10306.
Herald added a project: All.
persona0220 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This diff move the logic of `GetControlFlowKind()` from Disassembler.cpp to DisassemblerLLVMC.cpp.
Here's details:

- Similar to `CalculateMnemonicOperandsAndComment()` in Instruction class, added `CalculateControlFlowKind()` function to decode instruction control flow kind.
- Actual logic move to `DisassemblerLLVMC.cpp`, and we can check underlying architecture using `DisassemblerScope` there.
- With this change, passing 'triple' to `GetControlFlowKind()` is no more required.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130320

Files:
  lldb/include/lldb/Core/Disassembler.h
  lldb/source/Core/Disassembler.cpp
  lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp
  lldb/unittests/Disassembler/x86/TestGetControlFlowKindx86.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130320.446670.patch
Type: text/x-patch
Size: 24217 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220722/889a8d38/attachment-0001.bin>