[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.

This looks good to me.   I had a trivial comment about comments.  You added a test for the condition in lambda as well, that's great!



================
Comment at: lldb/include/lldb/Expression/Materializer.h:88
+  /// \param[in] name Name of variable to materialize
+  /// \param[in] valobj_provider When materializing values multiple
+  ///            times, this callback gets used to fetch a fresh
----------------
We seem to put empty /// lines between each of the parameters in most other places.  I think that makes them marginally easier to read, and it's what we do in most other places...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129078/new/

https://reviews.llvm.org/D129078