[Lldb-commits] [PATCH] D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList

Jorge Gorbe Moya via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 21 09:17:38 PDT 2022


jgorbe added inline comments.


================
Comment at: lldb/source/Commands/CommandObjectType.cpp:1064
+    // No regex means list everything.
+    return (regex == nullptr || (s == regex->GetText() || regex->Execute(s)));
+  }
----------------
labath wrote:
> What's up with all the parentheses? This is just a regular `||` between three choices...
Thanks for catching it. Fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130219/new/

https://reviews.llvm.org/D130219



More information about the lldb-commits mailing list