[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

@werat did you build with assertions enabled?

This change looks fine to me, but it might be interesting to see where the discrepancy between the platforms comes from.



================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7541
   // the type of the integer literal.
-  if (const EnumType *enum_type = llvm::dyn_cast<EnumType>(qt.getTypePtr())) {
+  if (const EnumType *enum_type = qt->getAs<EnumType>()) {
     const EnumDecl *enum_decl = enum_type->getDecl();
----------------
In case someone else is curious what the difference between before and after is:

https://clang.llvm.org/doxygen/Type_8h_source.html#l07302


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130213/new/

https://reviews.llvm.org/D130213