[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid added a comment.

In D129489#3665218 <https://reviews.llvm.org/D129489#3665218>, @DavidSpickett wrote:

>> You mean "memory read <the tagged memory buffer> --show-tags"? The details are tested on live processes already but a simple smoke test wouldn't hurt, I'll do that.
>
> I checked and to include the memory contents takes the core file from 20k to 300 something k. This isn't the end of the world but thinking about it, the code that powers "memory read --show-tags" is built on top of the stuff that's already tested here.
>
> And that show tags code is tested via unit tests and live processes elsewhere, so I don't think we need anything for it here.

Agreed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129489/new/

https://reviews.llvm.org/D129489