[Lldb-commits] [PATCH] D130098: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.

The changes themselves look good, but please undo the formatting/unrelated changes before landing this. When I've been in a situation like this where I accidentally formatted unrelated things, I usually unstage my changes and use `git add -p` to interactively pick the chunks I want to stage.

There's a script called `git-clang-format` that allows you to format only the lines that have been changed: https://clang.llvm.org/docs/ClangFormat.html#git-integration. Once you've added it to your PATH, you can run `git clang-format` after staging your changes (but before committing).



================
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4640
     uint32_t m_line_start = 0;
-    uint32_t m_line_end;
+    uint32_t m_line_end = UINT_MAX;
     std::string m_file_name;
----------------
`LLDB_INVALID_LINE_NUMBER`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130098/new/

https://reviews.llvm.org/D130098