[Lldb-commits] [PATCH] D130098: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan

[Greg Clayton via Phabricator via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

You missed a few comments. It would also be nice to remove the memset from the ObjectFilePECOFF by adding "= 0;" to all of the struct definitions in ObjectFilePECOFF.h that would be great as well.



================
Comment at: lldb/include/lldb/Core/EmulateInstruction.h:182
     eInfoTypeNoArgs
-  } InfoType;
+  };
 
----------------
I would revert this change as it isn't related to uninitialized vars.


================
Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:417
     : ObjectFile(module_sp, file, file_offset, length, data_sp, data_offset),
-      m_dos_header(), m_coff_header(), m_sect_headers(),
+      m_dos_header(), m_coff_header(), m_sect_headers(), m_image_base(),
       m_entry_point_address(), m_deps_filespec() {
----------------
m_image_base should be set to LLDB_INVALID_ADDRESS, I had a suggested code edit, but not sure if you saw it above.


================
Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:428
     : ObjectFile(module_sp, process_sp, header_addr, header_data_sp),
-      m_dos_header(), m_coff_header(), m_sect_headers(),
+      m_dos_header(), m_coff_header(), m_sect_headers(), m_image_base(),
       m_entry_point_address(), m_deps_filespec() {
----------------
m_image_base should be set to LLDB_INVALID_ADDRESS, I had a suggested code edit, but not sure if you saw it above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130098/new/

https://reviews.llvm.org/D130098