[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 7 06:40:49 PDT 2022


labath added inline comments.


================
Comment at: lldb/test/API/tools/lldb-server/vCont-threads/main.cpp:18
+std::atomic<bool> can_work = ATOMIC_VAR_INIT(false);
+thread_local bool can_exit_now = false;
 
----------------
mgorny wrote:
> labath wrote:
> > I guess this should technically be a `volatile sig_atomic_t`
> But with `thread_local`, correct?
Yes. If that's not enough qualifiers, you can even throw in `static`, for good measure. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129012/new/

https://reviews.llvm.org/D129012



More information about the lldb-commits mailing list